Additional group theory functions for error correction #351

IsaacP1234 · 2024-08-30T19:51:36Z

Adding logical_operator_canonicalize, commutavise, and embed functions, as well as SubsystemCodeTableau datastructure and minor performance improvements for groupify and normalizer.

IsaacP1234 · 2024-09-12T02:40:33Z

@KDGoodenough I have rewritten the documentation for canonicalize noncomm, commutify, and matroid_parent to be more clear, but is there anything about the functions or the theory behind them that I should include in the documentation?

…mClifford.jl into loc-comm-embed fixed merge conflict with origin

IsaacP1234 · 2024-09-15T20:53:16Z

I think I have completed all the requested changes, but I am not aware of more uses of commutify aside from matroid parent to add to its documentation. @KDGoodenough are there any I should add?

Additionally, should I add the newly-referenced papers to references.md?

KDGoodenough · 2024-09-16T05:25:27Z

@IsaacP1234 I think it's good like this! There's not too much work (yet!) that uses this commutify business. My guess would be that yes, it would be good to add these references to the .md file as well, but Stefan would know better.

IsaacP1234 · 2024-09-16T23:57:45Z

Changelog:

New error correction tools:
- canonicalize_noncomm function to find a generating set with minimal anticommutivity
- SubsystemCodeTableau data structure to represent the output of canonicalize_noncomm
- commutify function to find a commutative version of a non-commutative set of Paulis with
  minimal changes
- matroid_parent function to, for set of Paulis that doesn't represent a state, find a version
  that does.

…cally for you, causing less noise in PRs)

Krastanov

Finally got around to reviewing this. Thank you for all these additions and apologies for the long delay.

First, I made a few changes myself, but either github is having its usual reliability problems or you have set some security features a bit higher and I can not push to your branch.

Before you continue, could you please make sure that you pull the changes from this branch: https://github.com/QuantumSavory/QuantumClifford.jl/tree/loc-comm-embed

I tried to make each commit small and self-explanatory -- please check the commits I have added one-by-one to see why they were added.

Krastanov · 2024-09-27T20:05:22Z

src/grouptableaux.jl

+    m::Int
+    k::Int
+end
+function SubsystemCodeTableau(t::Tableau)


Why is this constructor necessary? It is a pretty expensive one. Should this not be a part of the canonicalize_noncomm function itself.

Krastanov · 2024-09-27T20:06:44Z

src/grouptableaux.jl

+end
+
+
+Base.copy(t::SubsystemCodeTableau) = SubsystemCodeTableau(copy(t.tab))


This is a very expensive way to make a copy as you are redoing a ton of computation. It would be better if this just copies over the various indices as well.

Krastanov · 2024-09-27T20:08:01Z

src/grouptableaux.jl

    for i in 0:2^n-1
        for (digit_order, j) in enumerate(digits(i, base=2, pad=n))
            if j == 1
-                group[i+1] *= s[digit_order]
+                group[i+1] *= gen_set[digit_order]


mul_left!(group, gen_set, i+1, digit_order) would be drastically faster (it will be in-place, avoiding a lot of allocations).

By the way, does this function work correctly if there are terms with non-trivial phases?

If there are non-real phases it doesn't work because it uses minimal_generating_set which only accepts real phases. Should I rework it to work with imaginary phases or specify in the docs that it only accepts real phases?

Additionally, there doesn't seem to be any method of mul_left! that can multiply a single row of a Tableau or Stabilizer by a Pauli. Just indexing doesn't change the original structure.

just writing down what we discussed in the call: just add a kwargument phases=false, and throw an error if someone tries to run phases=true with some message about it not being implemented

For mul_left! could you please just add a new method for it, basically just making a second more general version of this one in the same file

QuantumClifford.jl/src/mul_leftright.jl

Line 166 in 4e06c01

@inline function mul_left!(s::Tableau, m, i; phases::Val{B}=Val(true)) where B

I think it would be just

@inline function mul_left!(s::Tableau, m, t::Tableau, i; phases::Val{B}=Val(true)) where B extra_phase = mul_left!((@view s.xzs[:,m]), (@view t.xzs[:,i]); phases=phases) B && (s.phases[m] = (extra_phase+s.phases[m]+s.phases[i])&0x3) s end

and then do tab(stabilizer) wherever you call it

Krastanov · 2024-09-27T20:08:15Z

src/grouptableaux.jl

+julia> tab(logical_operator_canonicalize(QuantumClifford.Tableau([P"XX", P"XZ", P"XY"])))
+ Z_
+ XX
+-iX_


yup, let's just remove the phases

Krastanov · 2024-09-27T20:09:32Z

src/grouptableaux.jl

+                for k in eachindex(t)
+                    if k !=i && k != j
+                        if comm(t[k], t[i]) == 0x01
+                            t[k] = t[j] *t[k]


mul_left!

with phases=false

Krastanov · 2024-09-27T20:12:28Z

src/grouptableaux.jl

+                    loc[index]= t[i]
+                    index+=1
+                end
+                if !(t[j] in loc || -1 *t[j] in loc || 1im *t[j] in loc || -1im * t[j] in loc)


same comment about cost of check

Krastanov · 2024-09-27T20:13:05Z

src/grouptableaux.jl

+    while length(loc) > 1 && loc[length(loc)-1] == zero(PauliOperator, nqubits(loc)) 
+        loc = loc[1:(length(loc)-1)]
+    end
+    return SubsystemCodeTableau(loc)


Can you give the constructor more information so it does not run all that expensive processing and searching?

Krastanov · 2024-09-27T20:13:46Z

src/grouptableaux.jl

+        puttableau!(commutative, x, i, nqubits(loc)+i)
+        puttableau!(commutative, z, i+loc.r+loc.k, nqubits(loc)+i)
+    end
+    to_delete = []


something more like nqubits+1:nqubits+k would be much simpler and faster

Krastanov · 2024-09-27T20:17:15Z

src/grouptableaux.jl

+ ZZZ
+
+julia> matroid_parent(T"XX")[2]
+1-element Vector{Any}:


these should be ranges or vectors of ints, not vectors of any

Krastanov · 2024-09-27T20:17:20Z

src/grouptableaux.jl

+ 3
+
+julia> matroid_parent(T"XX")[3]
+Any[]


these should be ranges or vectors of ints, not vectors of any

Krastanov · 2024-09-27T20:28:43Z

by the way, to verify my claims about speed, you can use BenchmarkTools and the @benchmark macro

IsaacP1234 · 2024-10-02T23:23:31Z

All requested chnages complete. For the SubsystemCodeTableau constructor, I now format the Tableau in canonicalize_noncomm, but I left the expensive one in in case a Tableau generated from another function needs to be stored as a SubsystemCodeTableau

codecov · 2024-10-25T01:40:27Z

Codecov Report

Attention: Patch coverage is 67.24138% with 57 lines in your changes missing coverage. Please review.

Project coverage is 82.53%. Comparing base (0849b1c) to head (8f14bd3).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/grouptableaux.jl	66.27%	57 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   83.11%   82.53%   -0.59%     
==========================================
  Files          70       70              
  Lines        4418     4580     +162     
==========================================
+ Hits         3672     3780     +108     
- Misses        746      800      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Krastanov · 2024-10-25T02:47:01Z

Finally merged! Thanks so much!

KDGoodenough and others added 30 commits March 27, 2024 21:12

first commit

3ec3098

added GT dependecies to project.toml

dee1c59

started GT test file

a708c00

started groupify tests

8627fee

tests for groupify/generating set, pauli ops don't work

3bf54ae

removing unnecessary dependencies

4f377b7

removed print statements

929607d

completed get_gen_set tests

1161ff2

added phase arg to pualigroup and tests for normalize

da32a75

added tests for center, fixed center

09ea8b5

formatted tests

e2af6b7

added changes to changelog

c1510a0

removed SafeTestSets dependency, formatted changelog

f22cf6e

fixed center function and pauligroup phases

5ded49b

added tests for logical_op_canonicalize

59cf3be

updated LOC tests

2076a52

updated LOC tests and CHANGELOG

b7d0eab

updated GGS+tests to work with I operators

7694800

added method descriptions

bd5e63a

removed print statements + fixed center tests

d4265dd

fixed changelog grammar

b9071e1

formatted+commented unfinished functions

43f4736

fixed changelog

afa2d17

completed changelog

c1282d8

removed unnecessary comments

79f8f75

moved pauli delete to p_o.jl

0fc1725

removed changelog update to prevent merge conflicts

6029b7f

converted delete to deleteat! and moved to paulioperator.jl

d2bf12a

finished contract, cleaned up code, added documentation

b633615

added tests for contract

be86915

IsaacP1234 added 3 commits September 11, 2024 22:43

Merge branch 'loc-comm-embed' of https://github.com/IsaacP1234/Quantu…

04c4c29

…mClifford.jl into loc-comm-embed fixed merge conflict with origin

improved docs+added referencese

5257f1a

updated SSCT docs

64e1caa

IsaacP1234 added 2 commits September 16, 2024 14:14

fixed citing

ee7beb3

test error fix

c785372

IsaacP1234 requested a review from Krastanov September 17, 2024 00:01

Krastanov added 6 commits September 26, 2024 23:13

Merge branch 'master' into loc-comm-embed

023550f

fix whitespace issues (you can configure VScode to fix these automati…

7f71467

…cally for you, causing less noise in PRs)

ident in bibfile

b0bb5e1

re-enable the tests (why were they disabled?)

e50620b

doc and whitespace cleanup

bfccfe1

do not create a new pauli operator each time a phase is changed

39daadd

Krastanov requested changes Sep 27, 2024

View reviewed changes

IsaacP1234 added 3 commits October 1, 2024 00:16

added show and fixed copy for SSCT

06b9282

added mul_left method + fixed del_cols

ea023ca

changed constructor and updated groupify

b29e0f1

IsaacP1234 requested a review from Krastanov October 3, 2024 01:23

minor cleanup

dd95172

Krastanov and others added 3 commits October 24, 2024 21:48

Merge branch 'master' into loc-comm-embed

c118dba

changelog

3adf539

Merge branch 'master' into loc-comm-embed

8f14bd3

Krastanov merged commit f3eb7cd into QuantumSavory:master Oct 25, 2024
14 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional group theory functions for error correction #351

Additional group theory functions for error correction #351

IsaacP1234 commented Aug 30, 2024

IsaacP1234 commented Sep 12, 2024

IsaacP1234 commented Sep 15, 2024

KDGoodenough commented Sep 16, 2024

IsaacP1234 commented Sep 16, 2024

Krastanov left a comment

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

IsaacP1234 Sep 30, 2024

IsaacP1234 Sep 30, 2024

Krastanov Oct 2, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov Sep 27, 2024

Krastanov commented Sep 27, 2024

IsaacP1234 commented Oct 2, 2024

codecov bot commented Oct 25, 2024 •

edited

Loading

Krastanov commented Oct 25, 2024

		end


		Base.copy(t::SubsystemCodeTableau) = SubsystemCodeTableau(copy(t.tab))

Additional group theory functions for error correction #351

Additional group theory functions for error correction #351

Conversation

IsaacP1234 commented Aug 30, 2024

IsaacP1234 commented Sep 12, 2024

IsaacP1234 commented Sep 15, 2024

KDGoodenough commented Sep 16, 2024

IsaacP1234 commented Sep 16, 2024

Krastanov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krastanov commented Sep 27, 2024

IsaacP1234 commented Oct 2, 2024

codecov bot commented Oct 25, 2024 • edited Loading

Codecov Report

Krastanov commented Oct 25, 2024

codecov bot commented Oct 25, 2024 •

edited

Loading